Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[verify] Support multiple encryption keys #1087

Closed
viklund opened this issue Oct 16, 2024 · 1 comment · Fixed by #1235
Closed

[verify] Support multiple encryption keys #1087

viklund opened this issue Oct 16, 2024 · 1 comment · Fixed by #1235
Assignees

Comments

@viklund
Copy link
Member

viklund commented Oct 16, 2024

Main user story

As a security conscious user of the sensitive data arcive,
I want to see that the archive can rotate encryption keys
so that security can be maintained.

Sub user story

As an sda-dev
I want to implement multiple-key support for the verify services
so that repository key rotation can be enabled.

Description

  • Verify should be able to load a directory of public/private key pairs instead of just a specific one (same configuration as ingest).
  • Since verify reads all the keys from the directory should keep all the key hashes in memory for finding the private key to use without trying all the private keys.
  • For verify to pass for a file it should look up the hash of the key used to encrypt a file from the database and should then try to decrypt the file with that specific key.

Acceptance criteria

  • Demonstrate ingestion and verification of encrypted files with two different archive c4gh private keys.
  • Tests verifying the changes added

Extra information

This issue was split off from issue #787.

Note: key rotation miro board here

@aaperis
Copy link
Contributor

aaperis commented Dec 16, 2024

This issue is quite connected with #787 and will be more complex if done in parallel due to integration tests and all moving parts that need to be done together, so (after discussing it also with @nanjiangshu) I am putting it back to the stack for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants