Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and test SQL-statements for updating the database to remove user-ids from the filepaths #1123

Open
viklund opened this issue Nov 11, 2024 · 3 comments
Assignees

Comments

@viklund
Copy link
Member

viklund commented Nov 11, 2024

Once the services has been updated, legacy files has to be updated to reflect how the new stack works.

This needs to be thourougly tested. For example, use the integration tests and test before and after upgrade with old and new containers. Also make sure the download API works by fetching a file and listing in the end.

A/C:

A document with a SQL statement or similar that one can run on the production database to update the data.

@jbygdell
Copy link
Collaborator

UPDATE table SET path = REPLACE(LTRIM(path,'/'),username,'');

more or less

@kjellp
Copy link
Contributor

kjellp commented Nov 12, 2024

Sounds like this will be a possible breaking change. Is the plan to have the services (ingest pipeline and downliad/doa) supporting old and new style for some time? Or do "a hard shift" at an agreed point in time?

@jbygdell
Copy link
Collaborator

@kjellp this is related to #1097.

Ingest uses the filepath in the message not what's in the database, and it is your inbox that sends that message.
So the services primarily affected by this will be the API + data out components, since they reads the file paths from the DB.

That being said, we should probably start using separate tracks (v1, v2 ...) for this kind of stuff since updating a component prematurely will cause big issues.

@viklund viklund changed the title Update database to remove user-ids from the filepaths Create and test SQL-statements for updating the database to remove user-ids from the filepaths Nov 18, 2024
@pahatz pahatz self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants