Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect calculation of normalisation #4

Open
jwpleow opened this issue May 9, 2022 · 0 comments
Open

Incorrect calculation of normalisation #4

jwpleow opened this issue May 9, 2022 · 0 comments

Comments

@jwpleow
Copy link

jwpleow commented May 9, 2022

m_dual.coeffs() -= (m_real.coeffs().dot(m_dual.coeffs()) * lengthSqr) * m_real.coeffs();

Hi,
I think you have miscalculated the normalisation of the dual quaternion - you've already normalised both the primary and dual parts by the primary part's norm, so following the equation in https://math.stackexchange.com/questions/4445771/normalizing-a-dual-quaternion, you should only need to subtract the dual part by the dot product multipled by m_real, without needing the * lengthSqr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant