Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resync command #233

Open
devhawk opened this issue May 6, 2022 · 18 comments
Open

resync command #233

devhawk opened this issue May 6, 2022 · 18 comments
Labels
enhancement New feature or request

Comments

@devhawk
Copy link
Contributor

devhawk commented May 6, 2022

No description provided.

@devhawk devhawk added the enhancement New feature or request label May 6, 2022
@devhawk devhawk self-assigned this May 6, 2022
@devhawk devhawk removed their assignment Jul 31, 2023
@cschuchardt88
Copy link
Member

cschuchardt88 commented Nov 15, 2023

This would require some parts of blockchain-toolkit-library to be edited. For example Neo.BlockchainToolkit.Constants to add a default batch file and policy filename.

@Jim8y
Copy link
Contributor

Jim8y commented Nov 15, 2023

@shargon can we move https://github.com/N3developertoolkit/neo-blockchaintoolkit-library into the neo-project?

@cschuchardt88
Copy link
Member

I prefer it to be in neo-express repo

@Jim8y
Copy link
Contributor

Jim8y commented Nov 15, 2023

I prefer it to be in neo-express repo

That would be even better. I have no idea who is responsible to this repo, but i would suggest that we also make this one convenient to maintain. @Ashuaidehao @shargon

@Ashuaidehao
Copy link
Collaborator

I'm maintaining https://github.com/N3developertoolkit/neo-blockchaintoolkit-library.

@Jim8y
Copy link
Contributor

Jim8y commented Nov 15, 2023

I'm maintaining https://github.com/N3developertoolkit/neo-blockchaintoolkit-library.

@Ashuaidehao Then how do you think about the idea of merging toolkit into express?

@cschuchardt88
Copy link
Member

@Ashuaidehao you know i will help you. But I hate waiting for changes to be released to nuget to get updated package.

@Ashuaidehao
Copy link
Collaborator

I'm maintaining https://github.com/N3developertoolkit/neo-blockchaintoolkit-library.

@Ashuaidehao Then how do you think about the idea of merging toolkit into express?

I agree it. The only thing is how to make neo-express release github action going on.

@Ashuaidehao
Copy link
Collaborator

Ashuaidehao commented Nov 15, 2023

@Ashuaidehao you know i will help you. But I hate waiting for changes to be released to nuget to get updated package.

Yes, I remember you have done a lot of valuable work in #288 , thanks very much!

@Jim8y
Copy link
Contributor

Jim8y commented Nov 15, 2023

I'm maintaining https://github.com/N3developertoolkit/neo-blockchaintoolkit-library.

@Ashuaidehao Then how do you think about the idea of merging toolkit into express?

I agree it. The only thing is how to make neo-express release github action going on.

If you are looking for someone to trigger the release action, I can run it.

@Ashuaidehao
Copy link
Collaborator

I'm maintaining https://github.com/N3developertoolkit/neo-blockchaintoolkit-library.

@Ashuaidehao Then how do you think about the idea of merging toolkit into express?

I agree it. The only thing is how to make neo-express release github action going on.

I can run it.

Great! Do you check if the "NUGET_TOKEN" is expired?

@Jim8y
Copy link
Contributor

Jim8y commented Nov 15, 2023

Can some one fix this for me:

Run dotnet pack src/worknet --output ./out2 --configuration Release --no-restore --verbosity normal
dotnet pack src/worknet --output ./out2 --configuration Release --no-restore --verbosity normal
shell: /usr/bin/bash -e {0}
env:
DOTNET_ROOT: /home/runner/.dotnet
GitAssemblyInformationalVersion: 3.6.17+be7bf33b3b
GitBuildVersion: 3.6.17.48763
GitBuildVersionSimple: 3.6.17
MSBuild version 17.7.4+3ebbd7c49 for .NET
Build started 11/15/2023 10:39:52.
1>Project "/home/runner/work/neo-express/neo-express/src/worknet/neoworknet.csproj" on node 1 (pack target(s)).
1>PrepareForBuild:
Creating directory "bin/Release/net7.0/".
Creating directory "obj/Release/net7.0/".
Creating directory "/home/runner/work/neo-express/neo-express/src/worknet/obj/Release/net7.0/refint/".
Creating directory "obj/Release/net7.0/ref".
1>/home/runner/.dotnet/sdk/7.0.404/Sdks/Microsoft.NET.Sdk/targets/Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1004: Assets file '/home/runner/work/neo-express/neo-express/src/worknet/obj/project.assets.json' not found. Run a NuGet package restore to generate this file. [/home/runner/work/neo-express/neo-express/src/worknet/neoworknet.csproj]
1>Done Building Project "/home/runner/work/neo-express/neo-express/src/worknet/neoworknet.csproj" (pack target(s)) -- FAILED.

Build FAILED.

   "/home/runner/work/neo-express/neo-express/src/worknet/neoworknet.csproj" (pack target) (1) ->
   (ResolvePackageAssets target) -> 
     /home/runner/.dotnet/sdk/[7](https://github.com/neo-project/neo-express/actions/runs/6876167529/job/18701195718#step:8:7).0.404/Sdks/Microsoft.NET.Sdk/targets/Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK[10](https://github.com/neo-project/neo-express/actions/runs/6876167529/job/18701195718#step:8:11)04: Assets file '/home/runner/work/neo-express/neo-express/src/worknet/obj/project.assets.json' not found. Run a NuGet package restore to generate this file. [/home/runner/work/neo-express/neo-express/src/worknet/neoworknet.csproj]

0 Warning(s)
1 Error(s)

Time Elapsed 00:00:00.56
Error: Process completed with exit code 1.

Make it like:

  • name: Install dependencies
    run: dotnet restore src/worknet

  • name: Pack NeoWorkNet
    run: dotnet pack src/worknet --output ./out2 --configuration Release --no-restore --verbosity normal

@Jim8y
Copy link
Contributor

Jim8y commented Nov 15, 2023

@Ashuaidehao @cschuchardt88 please take a look at the new release

@cschuchardt88
Copy link
Member

@Liaojinghui I think we should add in #336 #335

@Jim8y
Copy link
Contributor

Jim8y commented Nov 15, 2023

Good to merge already?

@cschuchardt88
Copy link
Member

yes

@cschuchardt88
Copy link
Member

If arent good, than they will be Draft

@Jim8y
Copy link
Contributor

Jim8y commented Nov 15, 2023

If arent good, than they will be Draft

There are conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants