Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is recommended to remove the non-essential Network Versin from the config file #731

Open
RichardBelsum opened this issue Jun 15, 2022 · 3 comments

Comments

@RichardBelsum
Copy link
Contributor

  1. When installing a plugin, to manually modify the network number in the config file, I do not know the meaning of the existence of the network number.

  2. The plugins command lists plugins that may not work because of different network numbers, should they be improved.

@EdgeDLT
Copy link
Contributor

EdgeDLT commented Jun 20, 2022

The network magic is the network identifier.

But I think this would be a good improvement. Is there any use case for having plugins using a different network to the node itself? Can they not just use the same one as set in the node config?

@roman-khimov
Copy link
Contributor

Is there any use case for having plugins using a different network to the node itself?

IIRC in C# implementation that's what NeoFS plugin will do to be able to communicate with the NeoFS sidechain (#630).

@EdgeDLT
Copy link
Contributor

EdgeDLT commented Jun 30, 2022

IIRC in C# implementation that's what NeoFS plugin will do to be able to communicate with the NeoFS sidechain (#630).

Good example. I still think it would still be an improvement to remove the field and use the config file network number in other plugins. Modules that need to connect to other networks, like the NeoFS plugin, can still include overrides (or additional values) in their own configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants