Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Coding Standard #826

Open
cschuchardt88 opened this issue Sep 16, 2023 · 0 comments
Open

Plugin Coding Standard #826

cschuchardt88 opened this issue Sep 16, 2023 · 0 comments

Comments

@cschuchardt88
Copy link
Member

cschuchardt88 commented Sep 16, 2023

Summary or problem description
For example RpcClient method GetContractStateAsync doesn't even use its model class at all for serializing and deserializing .
image

RpcClient

  • RpcStateRoot No ToJson
  • RpcMethodToken No ToJson
  • RpcFoundStates No ToJson
  • GetContractStateAsync
  • Possibly More

Do you have any solution you want to propose?
We have some kind of standard for writing plugins; code in general. For example, Folder structure layout. Maybe Interfaces for certain things like getting storage from other plugins. Making and writing unit tests. A naming convention for properties names in config.json. Just to name a couple. If we don't as you can see things can get lost in time, as new requirements come along and deadlines need to be met. Also we can update .editorconfig file for most of these little things.

Where in the software does this update applies to?

  • Plugins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant