Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep using the latest MyGet Neo package when pushing a new PR #843

Open
superboyiii opened this issue Nov 13, 2023 · 2 comments
Open

Keep using the latest MyGet Neo package when pushing a new PR #843

superboyiii opened this issue Nov 13, 2023 · 2 comments

Comments

@superboyiii
Copy link
Member

superboyiii commented Nov 13, 2023

Summary or problem description
Currently the repo is using stable and released Neo from Nuget.org until a newer one comes out, then neo-modules can check and fix incompatilbe changes. This is risky and it puts every potential issues and fix into the end before release. It's not good to check all changes in the end and easy to forget sth.

Do you have any solution you want to propose?
We already have MyGet Neo package for each commit, it's better to update the latest Neo when pushing a new PR, then we could catch changes timely.

Where in the software does this update applies to?

  • all plugins even Neo-CLI

Need your opinion
@roman-khimov @shargon @vncoelho @cschuchardt88 @AnnaShaleva @Liaojinghui

@Jim8y
Copy link
Contributor

Jim8y commented Nov 13, 2023

I think this repo will also be added to the mono-repo, @roman-khimov, so it will directly use the neo-vm and neo-core source code.

@shargon
Copy link
Member

shargon commented Nov 13, 2023

This will be solved with mono-repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants