Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing wsport field of getversion RPC structure on RPC client side #867

Open
AnnaShaleva opened this issue Jan 10, 2024 · 2 comments
Open

Comments

@AnnaShaleva
Copy link
Member

Describe the bug
#859 removed WsPort property from RpcVersion class on the RPC client side. We need to get it back, because NeoGo RPC server still supports WS capability and NeoC# RPC client is capable of interacting with both C# and Go nodes. It's OK not to have this field on the NeoC# RPC server side since WS server was removed form the C# node.

Expected behavior
NeoC# RPC client should be able to properly unmarshal wsport field of the response to getversion RPC call.

Platform:

  • Version: RpcClient v3.6.3
@Jim8y
Copy link
Contributor

Jim8y commented Jan 10, 2024

Unless C# adds ws support, otherwise Wsport will not be add back.

@roman-khimov
Copy link
Contributor

What's the behavior now? The client will fail unmarshaling the response? Same thing can happen with new client accessing old server, please be careful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants