Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle: Add Other Mime Types #870

Open
cschuchardt88 opened this issue Jan 28, 2024 · 4 comments
Open

Oracle: Add Other Mime Types #870

cschuchardt88 opened this issue Jan 28, 2024 · 4 comments
Assignees

Comments

@cschuchardt88
Copy link
Member

Summary or problem description
Currently oracle only allow mime type application/json and if the server returns a mime type of application/json; charset=utf-8. This will invalidate the oracle request and throw an error code of 31.

Do you have any solution you want to propose?
Fix the logic to allow any mime type of application/json

Where in the software does this update applies to?

  • Oracle
@cschuchardt88
Copy link
Member Author

@Jim8y @shargon

@Jim8y
Copy link
Contributor

Jim8y commented Feb 19, 2024

@shargon can you please take a look?

@roman-khimov
Copy link
Contributor

  1. This limitation existed since the oracle implementation.
  2. But I never really understood it, it looks artificial and not helpful in any way. So I'm for allowing more, in general.
  3. We at the same time have JSON filters in the API now and this complicates the matter, we can't just enable any MIME types at the oracle module level, filter + non-JSON reply can't work.
  4. So maybe we need an additional request API at the oracle contract level for non-JSON things.

@shargon
Copy link
Member

shargon commented Feb 19, 2024

I think that currently it is not necessary, with json should be sufficient for current services, I also think that it's more interesting an aggregator of different sources, usually oracle is used for prices, and all the apis produce json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants