Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing manifest groups/trusts/features lead to an error that is hard to debug #3439

Open
roman-khimov opened this issue Jul 26, 2024 · 0 comments
Labels
Discussion Initial issue state - proposed but not yet accepted

Comments

@roman-khimov
Copy link
Contributor

Summary or problem description
nspcc-dev/neo-go#3522

The root cause there is missing groups, trusts and features from manifest. NEP-15 is rather strict about features and somewhat vague on groups/trusts, but we can assume that empty arrays are mandatory (can't be omitted) since that's the way it's implemented in C# and nothing explicitly allows them to be null.

But the problem for me in in these messages:
Missing groups: Value cannot be null. (Parameter 'source').
Missing trusts or features: One of the identified items was in an invalid format..

It'd be hard for a developer to decipher those.

Do you have any solution you want to propose?
Add some more specific errors for these.

Where in the software does this update applies to?

  • Ledger
@roman-khimov roman-khimov added the Discussion Initial issue state - proposed but not yet accepted label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Development

No branches or pull requests

1 participant