Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore dBFT Consensus Unit Tests #3231

Open
vncoelho opened this issue May 13, 2024 · 1 comment · May be fixed by #3473
Open

Restore dBFT Consensus Unit Tests #3231

vncoelho opened this issue May 13, 2024 · 1 comment · May be fixed by #3473
Assignees
@igormcoelho @Jim8y @vncoelho
Labels
Discussion Initial issue state - proposed but not yet accepted P1 High Priority: Targeting The Next Release
Milestone
v3.8.0

Comments

@vncoelho
Copy link
Member

vncoelho commented May 13, 2024 •
edited
Loading

Historically, we use to have Unit Tests for dBFT consensus.

After #3230 is migrated it would be very important to restore these tests, even minimally, testing basic functionalities.

In the future coverage can increase if we have a strong design for these tests.
@vncoelho vncoelho added the Discussion Initial issue state - proposed but not yet accepted label May 13, 2024
@vncoelho vncoelho added this to the v3.8.0 milestone May 13, 2024
@vncoelho
Copy link
Member Author

vncoelho commented Jun 3, 2024

Restore tests removed from #2212

@vncoelho vncoelho added the P1 High Priority: Targeting The Next Release label Jun 18, 2024
@Jim8y Jim8y mentioned this issue Jun 29, 2024
Open
14 tasks
This was referenced Aug 28, 2024
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igormcoelho igormcoelho

@Jim8y Jim8y

@vncoelho vncoelho

Labels
Discussion Initial issue state - proposed but not yet accepted P1 High Priority: Targeting The Next Release
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging a pull request may close this issue.

Restore DBFTPlugin Unit Tests (ConsensusService and Consensus Context) neo-project/neo
3 participants
@igormcoelho @Jim8y @vncoelho