Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit NEP on Tx Witness #103

Open
igormcoelho opened this issue Sep 2, 2019 · 1 comment
Open

Explicit NEP on Tx Witness #103

igormcoelho opened this issue Sep 2, 2019 · 1 comment

Comments

@igormcoelho
Copy link

We should be able to mark witness VerificationScript by some "standard script" identifier.

Examples:
PUSH signature / Check signature - Standard Verification 1
PUSH signatures / Check multisig - Standard Verification 2
etc

Some time ago (months), we discussed on a similar situation, with @shargon, and he wisely commented that it wouldn't be interesting to have a NEP to inform things that could not be true... I mean, tx submitter may "lie" about which verification format is. In this case, I propose that nodes verify the format, and reject tx if a specific format is declared, but not followed.

Example:
declare multisig, but perform single sig

Positive points: this allows us to do some optimizations, specially for blockchain explorers, as they will better know witnesses intentions, and clearly indicate that (single sig / multi sig / etc).
This is important for this NEP: #102

Negative points: this is an extra byte (if we limit to 255) on all cosigners, unless we manage to keep it optional somehow.

@roman-khimov
Copy link
Contributor

Seems like everyone is just parsing scripts to detect this and (three years down the road!) we still have just two main possibilities, probably it's OK as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants