Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need LP Tokens #175

Open
cschuchardt88 opened this issue Jun 19, 2024 · 5 comments
Open

We need LP Tokens #175

cschuchardt88 opened this issue Jun 19, 2024 · 5 comments

Comments

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jun 19, 2024

We need a way to id LP tokens on the network. There is many reasons why to have this.

Like https://eips.ethereum.org/EIPS/eip-7621

@Jim8y
Copy link
Contributor

Jim8y commented Jun 20, 2024

Expect 3 years.

@EdgeDLT
Copy link

EdgeDLT commented Jun 20, 2024

I don't want to say it's not useful, but I'm not following why this is necessary. What does ERC-7621 have to do with needing a standard to ID LP tokens? It doesn't use one. Does Ethereum even have such a standard? I've never heard of it.

I can't imagine a competent dApp developer using any kind of automatic aggregation when building token baskets or similar protocols that might use LP tokens. Sounds like a great way to get exploited.

@cschuchardt88
Copy link
Member Author

@roman-khimov
Copy link
Contributor

I'm not sure why we have it here. Does it require any changes to the core? I don't think so. It's something for proposals. Then interested parties (that actually do these things and I doubt it's core developers, it's more like Flamingo developers) can come up with something if they need to.

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jun 20, 2024

Well all the current LP tokens violate NEP-17 any ways. Shouldn't even have NEP-17 as a "supported" in their contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants