Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile+k8s+update #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

maxyloon
Copy link

@maxyloon maxyloon commented Feb 8, 2022

No description provided.

Copy link
Contributor

@akollegger akollegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you Max!

app: community-graphql
spec:
containers:
- image: 715633473519.dkr.ecr.us-east-1.amazonaws.com/community-graphql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the image produced from the Dockerfile pushed up to AWS, right? Is there a sensible way to parameterize this to move towards a git action workflow for redeployment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants