Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple getter for configs by mod and the loaded configs #185

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

Technici4n
Copy link
Member

@Technici4n Technici4n commented Jul 18, 2024

Quite simple and useful, especially for alternative config screen implementations that have a different strategy. Requested by @Speiger in neoforged/NeoForge#1336.

Fixes neoforged/NeoForge#1336.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jul 18, 2024

  • Publish PR to GitHub Packages

Last commit published: 7a74eaa59419d67ed6ea7f2b75a4d68e179a169a.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #185' // https://github.com/neoforged/FancyModLoader/pull/185
        url 'https://prmaven.neoforged.net/FancyModLoader/pr185'
        content {
            includeModule('net.neoforged.fancymodloader', 'loader')
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
            includeModule('net.neoforged.fancymodloader', 'junit-fml')
        }
    }
}

@Speiger
Copy link

Speiger commented Jul 18, 2024

@Technici4n why List.copyOf instead of Collections.unmodifiableList? (Wrap instead of copy i mean)
Just curious of the thought process here

@Technici4n Technici4n changed the title Add simple getter for configs by mod Add simple getter for configs by mod and the loaded configs Jul 24, 2024
shartte
shartte previously approved these changes Jul 28, 2024
@Technici4n Technici4n merged commit 11f1ec3 into neoforged:main Jul 28, 2024
3 checks passed
@Technici4n Technici4n deleted the get-mod-configs branch July 28, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reimplement config accessors
4 participants