JarJar does not skip loading libraries that are already on the classpath

[Technici4n]

identifyMod is used by JarJar to skip jar-in-jar'ed dependencies that are already loaded. For libraries however, it returns the file name which makes it impossible to override a jar-in-jar'ed dependency with a different version. It would be better to return the module name for libraries.

FancyModLoader/loader/src/main/java/net/neoforged/fml/loading/moddiscovery/locators/JarInJarDependencyLocator.java

Lines 111 to 117 in a9958a7

	protected String identifyMod(final IModFile modFile) {
	if (modFile.getModFileInfo() == null || modFile.getModInfos().isEmpty()) {
	return modFile.getFileName();
	}
	return modFile.getModInfos().stream().map(IModInfo::getModId).collect(Collectors.joining());
	}

[lukebemish]

If I understand how that works right, the identity stuff for files with a mod ID is also wrong there -- you could have a library jarar-ed with mods foo and bar and a root level file with the single mod foobar and the latter would replace the former which is wrong. Simple fix is to just join by something that's not part of a mod ID, right? Maybe ,, that's done elsewhere.

[Technici4n]

Fixed by #206.