Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HolderOwners being wrapped messing up RegistryFixedCodec #1644

Closed
ZestyBlaze opened this issue Oct 30, 2024 · 1 comment · Fixed by #1648
Closed

HolderOwners being wrapped messing up RegistryFixedCodec #1644

ZestyBlaze opened this issue Oct 30, 2024 · 1 comment · Fixed by #1648
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error data driven This request involves a data driven system

Comments

@ZestyBlaze
Copy link
Contributor

ZestyBlaze commented Oct 30, 2024

Minecraft Version: 1.21.3

NeoForge Version: 21.3.4-beta

Logs: https://mystb.in/b439b04c0f19ac9874

Steps to Reproduce:

  1. Clone my mod locally
  2. Trying doing runData task, experience crash

Description of issue:
This is being opened just as we try figure out what's going on but it's potentially an issue due to the way Neoforge wraps HolderOwner.
After a lot of discussion here, we came to a soft conclusion that everything in the code looks "right" and as it should. The Datapack Registry exists, and my Datamaps run okay until I try referring it to a RegistryFixedCodec instead of a direct codec, this is where the game starts crashing on running data now.
Commoble then suggested here that maybe due to Neoforge wrapping holderowners, it could be causing it to fail to serialise in a RegistryFixedCodec due to it becoming false, causing the error potentially.
Wanted to pop this up because if it is a bug with NF, it's halted my mod's progression for the mean time and I can't go any further with it just yet until a solution is found XD

@ZestyBlaze ZestyBlaze added the triage Needs triaging and confirmation label Oct 30, 2024
@XFactHD XFactHD added bug A bug or error data driven This request involves a data driven system 1.21.3 Targeted at Minecraft 1.21.3 and removed triage Needs triaging and confirmation labels Oct 31, 2024
@XFactHD XFactHD linked a pull request Oct 31, 2024 that will close this issue
@neoforged-releases
Copy link

🚀 This issue has been resolved in NeoForge version 21.3.6-beta, as part of #1648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error data driven This request involves a data driven system
Projects
None yet
2 participants