Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.3] TagsUpdatedEvent does not fire on clients after connecting to a dedicated server #1694

Closed
Fuzss opened this issue Nov 19, 2024 · 1 comment · Fixed by #1736
Closed

[1.21.3] TagsUpdatedEvent does not fire on clients after connecting to a dedicated server #1694

Fuzss opened this issue Nov 19, 2024 · 1 comment · Fixed by #1736
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error regression Worked previously but doesn't anymore

Comments

@Fuzss
Copy link

Fuzss commented Nov 19, 2024

Minecraft Version: 1.21.3

NeoForge Version: 21.3.34

There is simply a patch missing for firing the event in ClientConfigurationPacketListenerImpl.

Fabric patches their callback in at the lambda passed to ClientConfigurationPacketListenerImpl::runWithResources in ClientConfigurationPacketListenerImpl::handleConfigurationFinished just after RegistryDataCollector::collectGameRegistries is called.

Currently the event only fires in ClientPacketListener::handleUpdateTags on the client-side, which only seems to handle data reloads, but not the initial load when joining.
@Fuzss Fuzss added the triage Needs triaging and confirmation label Nov 19, 2024
@Fuzss Fuzss changed the title [1.21.3] TagsUpdatedEvent does not fire on a client after connecting to a server [1.21.3] TagsUpdatedEvent does not fire on clients after connecting to a dedicated server Nov 19, 2024
@sciwhiz12 sciwhiz12 added bug A bug or error regression Worked previously but doesn't anymore 1.21.3 Targeted at Minecraft 1.21.3 and removed triage Needs triaging and confirmation labels Nov 20, 2024
@Matyrobbrt Matyrobbrt mentioned this issue Dec 4, 2024
Merged
@neoforged-releases
Copy link

🚀 This issue has been resolved in NeoForge version 21.4.33-beta, as part of #1736.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error regression Worked previously but doesn't anymore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fire TagsUpdatedEvent on the client side after joining a server Matyrobbrt/NeoForge
2 participants
@sciwhiz12 @Fuzss