Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.4] Missing json files when generating Item Models #1742

Open
Stein-N opened this issue Dec 5, 2024 · 3 comments · May be fixed by #1725
Open

[1.21.4] Missing json files when generating Item Models #1742

Stein-N opened this issue Dec 5, 2024 · 3 comments · May be fixed by #1725
Labels
1.21.4 Targeted at Minecraft 1.21.4 blocks stable Blocks stable release data driven This request involves a data driven system enhancement New (or improvement to existing) feature or request

Comments

@Stein-N
Copy link

Stein-N commented Dec 5, 2024

Minecraft Version: 1.21.4

NeoForge Version: 21.4.7-beta

Logs: no logs

Steps to Reproduce:

  1. Create a class that extends the ItemModelProvider
  2. use basicItem() to generate an Item Model

Description of issue:
The problem here is that it only generates the json file inside the assets/mod_id/models/item directory but not the ItemModelModifier json inside the assets/mod_id/items directory.
Also there is currently no way to alter the Modifier for items

@Stein-N Stein-N added the triage Needs triaging and confirmation label Dec 5, 2024
@XFactHD XFactHD added enhancement New (or improvement to existing) feature or request blocks stable Blocks stable release data driven This request involves a data driven system 1.21.4 Targeted at Minecraft 1.21.4 and removed triage Needs triaging and confirmation labels Dec 5, 2024
@XFactHD
Copy link
Member

XFactHD commented Dec 5, 2024

The custom model providers provided by NeoForge have not been updated to generate the item model definition files because we are working on replacing them with patches to the vanilla providers. This will be resolved once #1725 is merged.

@Stein-N
Copy link
Author

Stein-N commented Dec 6, 2024

When i understand that PR correct the datagen will be comparible in any maner to the fabric datagen, when it comes to usability of all Vanilla Tools and helper methods right?

@XFactHD
Copy link
Member

XFactHD commented Dec 14, 2024

Yes, the vanilla helpers will be usable the same way they are in Fabric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 blocks stable Blocks stable release data driven This request involves a data driven system enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants