Add getter for baked standalone models #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last commit published: 8f5503d55714d875684aca37f299c1ec8056c61a. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1751' // https://github.com/neoforged/NeoForge/pull/1751
url 'https://prmaven.neoforged.net/NeoForge/pr1751'
content {
includeModule('net.neoforged', 'neoforge')
includeModule('net.neoforged', 'testframework')
}
}
}MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1751
cd NeoForge-pr1751
curl -L https://prmaven.neoforged.net/NeoForge/pr1751/net/neoforged/neoforge/21.4.12-beta-pr-1751-add-standalone-model-getter/mdk-pr1751.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zipTo test a production environment, you can download the installer from here. |
XFactHD
approved these changes
Dec 9, 2024
|
🚀 This PR has been released as NeoForge version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to actually retrieve the baked standalone models, which is no longer possible using the default
ModelManager#getModeldue to them being put into a separate map. I opted to add a separate getter rather than injecting them into thebakedBlockStateModelssince the latter would require constructingModelResourceLocationkeys for all of them, which we don't seem to do anymore.