Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: obj loader not rendering parts with the same name [1.21.4] #1759

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix: obj loader not rendering parts with the same name [1.21.4] #1759

merged 2 commits into from
Dec 11, 2024

Conversation

IThundxr
Copy link
Contributor

Fixes #1755 on 1.21.4

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@IThundxr IThundxr changed the title fix: obj loader not rendering parts with the same name fix: obj loader not rendering parts with the same name [1.21.4] Dec 11, 2024
@sciwhiz12 sciwhiz12 added bug A bug or error 1.21.4 Targeted at Minecraft 1.21.4 labels Dec 11, 2024
sciwhiz12
sciwhiz12 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and it works. The sugar glider block with the same part names renders correctly with the fix, and renders incorrectly (only one element visible) without it.

@sciwhiz12 sciwhiz12 merged commit 2f7ee38 into neoforged:1.21.x Dec 11, 2024
6 checks passed
@sciwhiz12 sciwhiz12 mentioned this pull request Dec 11, 2024
Merged
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.14-beta.

@neoforged-releases neoforged-releases bot mentioned this pull request Dec 11, 2024
Closed
@IThundxr IThundxr deleted the pr/1755 branch December 31, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sciwhiz12 sciwhiz12 sciwhiz12 approved these changes

Assignees
No one assigned
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OBJ Loader does not support parts with the same name
2 participants
@IThundxr @sciwhiz12