Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla swallows item asset errors in loading, NeoForge re-add? #1776

Open
Tslat opened this issue Dec 15, 2024 · 2 comments · May be fixed by #1789
Open

Vanilla swallows item asset errors in loading, NeoForge re-add? #1776

Tslat opened this issue Dec 15, 2024 · 2 comments · May be fixed by #1789
Labels
1.21.4 Targeted at Minecraft 1.21.4 enhancement New (or improvement to existing) feature or request

Comments

@Tslat
Copy link

Tslat commented Dec 15, 2024

With the new setup in 1.21.4, Vanilla is now silently swallowing errors for some things related to loading in item assets.

For example, if you don't have an assets/<modid>/items/<item_id>.json file at all (which is required for all items), the game will silently load in the missing texture/model, but won't print anything to log.
I believe it's also swallowing some others, such as if the target model the items asset designates doesn't exist (although it does print errors if the target model is invalid json

Any chance NeoForge could add these for usability? Especially given this is an entirely new asset location and system, users are going to be incredibly confused.

@Tslat Tslat added the enhancement New (or improvement to existing) feature or request label Dec 15, 2024
@TelepathicGrunt TelepathicGrunt added the 1.21.4 Targeted at Minecraft 1.21.4 label Dec 15, 2024
@XFactHD XFactHD linked a pull request Dec 20, 2024 that will close this issue
@XFactHD
Copy link
Member

XFactHD commented Dec 20, 2024

The most likely reason why vanilla doesn't log anything anymore is that there is no way to know all missing models during reload anymore and while there is currently still a way to check at least the default model for all items during resource reload (which is what my PR adds), the intention once items are data-driven seems to be to not require doing a resource reload when connecting to a server with custom items, at which point it is impossible to check pre-emptively check for missing models.

@Tslat
Copy link
Author

Tslat commented Dec 21, 2024

Right but even when the item tries to use the asset, it'll fail out with an error model and not tell you why

It's not even just for presumptive assets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants