Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NeoForge fluid ingredient types not being registered #1783

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Technici4n
Copy link
Member

Fixes #1780.

  • Added the missing DR register call.
  • This exposed a bug in how the codec is constructed, so I added a Codec.lazyInitialized call to fix it.
  • I also added a simple round-trip test, and reactivated a test that was missing a @Test annotation.

@neoforged-automation neoforged-automation bot added the 1.21.4 Targeted at Minecraft 1.21.4 label Dec 15, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Dec 15, 2024

  • Publish PR to GitHub Packages

Last commit published: 4e032eaaef77f9cfc940263d855c51c0d749bde7.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1783' // https://github.com/neoforged/NeoForge/pull/1783
        url 'https://prmaven.neoforged.net/NeoForge/pr1783'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1783.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1783
cd NeoForge-pr1783
curl -L https://prmaven.neoforged.net/NeoForge/pr1783/net/neoforged/neoforge/21.4.29-beta-pr-1783-fix-1780/mdk-pr1783.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Matyrobbrt Matyrobbrt added the bug A bug or error label Dec 16, 2024
@Technici4n Technici4n merged commit 24b9991 into neoforged:1.21.x Dec 16, 2024
7 checks passed
@Technici4n Technici4n deleted the fix-1780 branch December 16, 2024 09:17
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.29-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NeoForgeMod.FLUID_INGREDIENT_TYPES is not registered to the mod event bus
3 participants