Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styleguide #157

Open
newick opened this issue Aug 17, 2017 · 7 comments
Open

Styleguide #157

newick opened this issue Aug 17, 2017 · 7 comments

Comments

@newick
Copy link
Contributor

newick commented Aug 17, 2017

To stay consistent with the design we need to have a ressource somewhere to find the good code, the good colors, etc.

A solution is a styleguide (examples: http://styleguides.io/) also named pattern librairy.

My first idea is to create all the code we need there before adding it to the templates.
I like the atomic idea which is used on pattern lab.
All basics styles are atoms, a mix of atoms is a molecule, many molecules make a component, components create a template.

We spoke about it with @vinyll and thought about doing it with CSS vars helped with post processor like PostCSS

We'd like to have different CSS files only called if the component exists in the page.
There would be a common one for the layout, header, footer in every page and in particular page some particular styles (includes exist in Sass, what about PostCSS?)

It could be where we explain how we express ourself in the content ('your' or 'my' in menu for example)

Let's discuss that :)

@fuentesloic
Copy link
Member

fuentesloic commented Aug 18, 2017

my only comment about that: warm potetoessss (chaud patate!!) 🥇

I like the idea about atom -> molecule -> component -> template

Sure I agree with calling CSS only if it's needed, atom after atom

@newick Could you detail the steps to do ? because I understand the way and the finality but I lost in my mind about "how" ...

@newick
Copy link
Contributor Author

newick commented Aug 18, 2017

@fuentesloic Is it ok for you to start from the styleguide and then apply on the website?

I can start to do a bit of tree view, test it and we'll see then to fill it with existing components.

Another question is: do we put styleguide in website repo or in an dedicated one?
If it's another repo we'll have to create a rule to deploy styles from styleguide to website. I like this idea, like this no CSS is created in website, only in styleguide.
@vinyll any opinion?

@fuentesloic
Copy link
Member

@newick, Yep totally, and I agree with you to put all the css in a dedicated one.

@newick
Copy link
Contributor Author

newick commented Aug 18, 2017

@vinyll
Copy link
Member

vinyll commented Aug 18, 2017

+1 to have a dedicated repo for a styleguide.
I'm not sure how it works to require importing styles from a repo to another. Is it just a file to copy from one repo to another? If so, we could create a task make import-styleguide or something that would do the job.

@vinyll
Copy link
Member

vinyll commented Aug 20, 2017

@newick: I believe we've had this prepared for a while now: https://github.com/neomad-team/styleguide and https://neomad-team.github.io/styleguide/

@newick
Copy link
Contributor Author

newick commented Aug 21, 2017

@vinyll yep that's a basis, let's improve it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants