Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes with fw v0.5.x #22

Open
SamAlexandrov opened this issue Feb 3, 2021 · 1 comment
Open

Changes with fw v0.5.x #22

SamAlexandrov opened this issue Feb 3, 2021 · 1 comment

Comments

@SamAlexandrov
Copy link

The control mode names have changed, for example:
axis.controller.config.control_mode = CONTROL_MODE_VELOCITY_CONTROL
instead of
axis.controller.config.control_mode = CTRL_MODE_VELOCITY_CONTROL

I personally edited it in the odrive_interface.py and now the ROS node works again. Not sure how to approach it - maybe create a release with tag 0.5.x?

@neomanic
Copy link
Owner

neomanic commented Feb 3, 2021

Hi Sam,

I've just added an archive notice since I no longer have access to testing. If you want to prep a pull request for the change, I can add it. But try to keep backwards compatibility, perhaps the easiest way is to replace the old constants, but at the top of the file do a version check for older versions, and add the equivalents of CONTROL_MODE_VELOCITY_CONTROL = CTRL_MODE_VELOCITY_CONTROL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants