Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaling algorithm should use ceil(...) not round(...) for CPU goal CU #1212

Open
sharnoff opened this issue Jan 20, 2025 · 0 comments
Open

Scaling algorithm should use ceil(...) not round(...) for CPU goal CU #1212

sharnoff opened this issue Jan 20, 2025 · 0 comments
Labels
a/tech_debt Area: related to tech debt c/autoscaling/autoscaler-agent Component: autoscaling: autoscaler-agent

Comments

@sharnoff
Copy link
Member

From #1107 (comment):

Currently, CPU is the only resource for which we calculate goal CU by math.Round instead of math.Ceil. This is inconsistent, and probably not the desired behavior.

This would have been addressed as part of #1107, but I didn't want to hide a scaling algorithm change inside a big new feature that's mostly unrelated.
@sharnoff sharnoff added the c/autoscaling/autoscaler-agent Component: autoscaling: autoscaler-agent label Jan 20, 2025
@sharnoff sharnoff mentioned this issue Jan 20, 2025
Merged
@stradig stradig added the a/tech_debt Area: related to tech debt label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a/tech_debt Area: related to tech debt c/autoscaling/autoscaler-agent Component: autoscaling: autoscaler-agent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sharnoff @stradig