Skip to content

Commit

Permalink
Prefetch on macos (#9875)
Browse files Browse the repository at this point in the history 
## Problem

Prefetch is disabled at MacODS because `posix_fadvise` is not available.
But Neon prefetch is not using this function and for testing at MacOS is
it very convenient that prefetch is available.

## Summary of changes

Define `USE_PREFETCH` in Makefile.

---------

Co-authored-by: Konstantin Knizhnik <[email protected]>
  • Loading branch information
@knizhnik
knizhnik and Konstantin Knizhnik authored Nov 25, 2024
1 parent 77630e5 commit 441612c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ ifeq ($(UNAME_S),Linux)
# Seccomp BPF is only available for Linux
PG_CONFIGURE_OPTS += --with-libseccomp
else ifeq ($(UNAME_S),Darwin)
PG_CFLAGS += -DUSE_PREFETCH
ifndef DISABLE_HOMEBREW
# macOS with brew-installed openssl requires explicit paths
# It can be configured with OPENSSL_PREFIX variable
Expand Down

1 comment on commit 441612c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6853 tests run: 6544 passed, 2 failed, 307 skipped (full report)

Failures on Postgres 17

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_perf_counters[debug-pg17] or test_ondemand_download_replica[debug-pg17-4]"
Flaky tests (1)

Postgres 15

Test coverage report is not available

The comment gets automatically updated with the latest test results
441612c at 2024-11-25T17:59:12.877Z :recycle:

Please sign in to comment.