Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage controller: make consistency_check API work with different TenantConf formats #10369

Closed
jcsp opened this issue Jan 13, 2025 · 0 comments · Fixed by #10422
Closed

storage controller: make consistency_check API work with different TenantConf formats #10369

jcsp opened this issue Jan 13, 2025 · 0 comments · Fixed by #10422
Assignees
@jcsp
Labels
c/storage/controller Component: Storage Controller t/bug Issue Type: Bug

Comments

@jcsp
Copy link
Collaborator

jcsp commented Jan 13, 2025

Currently if the database has some more/fewer fields than the latest TenantConf definition, consistency check will consider all existing shards to be in an inconsistent state.
@jcsp jcsp added c/storage/controller Component: Storage Controller t/bug Issue Type: Bug labels Jan 13, 2025
@jcsp jcsp self-assigned this Jan 13, 2025
jcsp added a commit that referenced this issue Jan 16, 2025
@jcsp
storage controller: handle legacy TenantConf in consistency_check
2118484 
Closes: #10369
@jcsp jcsp mentioned this issue Jan 16, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 16, 2025
@jcsp
storage controller: handle legacy TenantConf in consistency_check (#1…
2e13a3a 
…0422)

## Problem

We were comparing serialized configs from the database with serialized
configs from memory. If fields have been added/removed to TenantConfig,
this generates spurious consistency errors. This is fine in test
environments, but limits the usefulness of this debug API in the field.

Closes: #10369

## Summary of changes

- Do a decode/encode cycle on the config before comparing it, so that it
will have exactly the expected fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsp jcsp

Labels
c/storage/controller Component: Storage Controller t/bug Issue Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

storage controller: handle legacy TenantConf in consistency_check neondatabase/neon
1 participant
@jcsp