-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Un-fork Azure SDK #10404
Comments
Note: whether using our |
The azure SDK's usage of tokio isn't the issue. We've already been heavy tokio users before, and are still such users now. The problem is that So in other words, the fork was made in order to include Azure/azure-sdk-for-rust#1654. A bit unrelated, but as you mention We used this ability in #10169 to enable reqwest's http connection pooling (option enabled in #10324). So far the reqwest issue that motivated turning off http connection pooling in the SDK didn't manifest for us, but pooling solved an important issue for us. Namely, before we were running into tcp port exhaustion issues on our servers because we were uploading a lot of files to Azure Blob Storage very quickly, and each upload would mean one new http connection on top of one new tcp stream, both of which would then promptly be closed. The kernel keeps the port of tcp streams allocated for a while after the stream has been closed ( |
Starting with #10036, we are using a forked version of the Azure SDK so that we only use one async runtime instead of two.
Blockers for un-forking:
legacy
branch of the SDK).The text was updated successfully, but these errors were encountered: