Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safekeeper: return AppendResponse on txn commit #9690

Open
Tracked by #9624
erikgrinaker opened this issue Nov 8, 2024 · 0 comments
Open
Tracked by #9624

safekeeper: return AppendResponse on txn commit #9690

erikgrinaker opened this issue Nov 8, 2024 · 0 comments
Assignees
Labels
a/performance Area: relates to performance of the system c/storage/safekeeper Component: storage: safekeeper

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Nov 8, 2024

Currently, when ingesting pipelined AppendRequest, we only flush the WAL and return an AppendResponse every second. This is despite the WAL implicitly getting flushed on segment bounds (see #9688).

However, consider a concurrent writer who inserts a single row. This writer must wait up to 1 second before an AppendResponse with a new flush_lsn allows the transaction to commit.

We should consider eagerly flushing and returning an AppendResponse when the WAL contains a transaction commit. This provides the same behavior as vanilla Postgres, where a txn commit forces an immediate WAL flush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/performance Area: relates to performance of the system c/storage/safekeeper Component: storage: safekeeper
Projects
None yet
Development

No branches or pull requests

1 participant