Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid our unsafe impl Send + Sync by pushing it upstream #53

Open
problame opened this issue Sep 5, 2024 · 1 comment
Open

avoid our unsafe impl Send + Sync by pushing it upstream #53

problame opened this issue Sep 5, 2024 · 1 comment

Comments

@problame
Copy link
Collaborator

problame commented Sep 5, 2024

(This issue has been an internal draft since Apr 30 for no good readon)


tokio-epoll-uring currently has to do some unsafe impl Send + Sync:

unsafe impl Send for CompletionSide {}

// SAFETY: we never use the raw IoUring pointer and it's not thread-local or anything like that.
unsafe impl Send for System {}
// SAFETY: we never use the raw IoUring pointer and it's not thread-local or anything like that.
unsafe impl Sync for System {}

unsafe impl Send for SubmitSideOpen {}
unsafe impl Sync for SubmitSideOpen {}

These are necessary because the underlying io_uring crate's Submitter, SubmissionQueue, and CompletionQueue struct are not impl Send + Sync, even though they could be.



Week starting May 6: pause one week, solicit feedback on Discord next week.

2024-05-28: reached out on Discord

@problame problame assigned problame and unassigned problame Sep 5, 2024
@problame
Copy link
Collaborator Author

problame commented Sep 5, 2024

Unassigned myself and moved the issue into Backlog state in our internal GH Project.
The reason is that there's no interest upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant