Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New design (and structure) #95

Merged
merged 51 commits into from
Jan 25, 2023
Merged

New design (and structure) #95

merged 51 commits into from
Jan 25, 2023

Conversation

manuelmeister
Copy link
Collaborator

@manuelmeister manuelmeister commented Oct 18, 2022 •
edited
Loading

I've tried to make the design more legible and tried to make it more noob friendly. I used the old vitepress theme as a base.

image

Preview: https://instance-7602d6b0-3aac-4c9a-bd63-6f382cbf56aa.flownative.cloud/

Content (this will be discussed and changed after the new design is deployed)

  • Made Home like a landing page for Devs
  • Add FusionPen Examples
  • Restrucutred Migrations
  • API Fusion Syntax Examples
  • Installation Guide restructured to focus on us cases and not operating systems and use cases
    • System Requirements updated

Improvements

  • Improved visual hierarchy in guide
  • Typography more focused on reading docs
  • Multiple different sidebars (based on top level)
  • Made Tutorials more readable and added sidebar "filter"
  • Dynamic navbar
  • New Fusion Syntax Highlighter that also better matches include: paths
  • Syntax Highlighter Eel in Fusion is rendered like JS and highlights important variables like props,…
  • Improve Pagespeed

@crydotsnake
Copy link
Member

The preview instance is not working anymore 😕

@manuelmeister
Copy link
Collaborator Author

Sorry my trial at @flownative ran out.

@kdambekalns
Copy link
Member

Sorry my trial at @flownative ran out.

You could have asked for stage instance to be set up in the Neos project… 😜

@robertlemke
Copy link
Member

@manuelmeister I configured the new Beach instance so that the free trial does not expire.

@manuelmeister
Copy link
Collaborator Author

@robertlemke @kdambekalns sorry, ich hatte es auch vergessen gehabt und habe jetzt halt noch einmal eine neue Instanz gemacht: https://instance-7602d6b0-3aac-4c9a-bd63-6f382cbf56aa.flownative.cloud/

jonnitto
jonnitto previously requested changes Nov 22, 2022
View reviewed changes
Copy link
Member

@jonnitto jonnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review, more will follow, but hey! thanks for your work ❤️

...onPackages/Neos.DocsNeosIo/Resources/Private/Fusion/Component/NavBar/NavBarItemDialog.fusion Outdated Show resolved Hide resolved
...ckages/Neos.DocsNeosIo/Resources/Private/Fusion/Component/NavBar/NavBarItemDialogItem.fusion Outdated Show resolved Hide resolved
DistributionPackages/Neos.DocsNeosIo/NodeTypes/Content/ApiSection.yaml Outdated Show resolved Hide resolved
DistributionPackages/Neos.DocsNeosIo/NodeTypes/Content/ApiSection.yaml Outdated Show resolved Hide resolved
DistributionPackages/Neos.DocsNeosIo/NodeTypes/Override/Override.Node.yaml Outdated Show resolved Hide resolved
...ibutionPackages/Neos.DocsNeosIo/Resources/Private/Fusion/Component/Layout/Layout.Home.fusion Outdated Show resolved Hide resolved
DistributionPackages/Neos.DocsNeosIo/Resources/Private/Fusion/Component/Layout/Layout.fusion Outdated Show resolved Hide resolved
...osIo/Resources/Private/Fusion/Component/LocalNavigation/LocalNavigation.LevelRenderer.fusion Outdated Show resolved Hide resolved
...ages/Neos.DocsNeosIo/Resources/Private/Fusion/Component/Sidebar/Sidebar.LevelRenderer.fusion Outdated Show resolved Hide resolved
DistributionPackages/Neos.DocsNeosIo/Resources/Private/Fusion/Content/Tabs/Tabs.fusion Outdated Show resolved Hide resolved
@manuelmeister
Update design to use cut off edges instead of rounded ones
56be455
@manuelmeister
Merge remote-tracking branch 'upstream/master' into feature/improve-ui
aa08c0e 
# Conflicts:
#	DistributionPackages/Neos.DocsNeosIo/Resources/Private/Fusion/Component/Footer/Footer.fusion
@mhsdesign
Copy link
Member

Wow ❤️

@manuelmeister manuelmeister changed the title New design and structure New design (and structure) Nov 28, 2022
@markusguenther
Copy link
Member

markusguenther commented Nov 29, 2022 •
edited
Loading

I am on an 8.1 update and when this is done I hope that the rebase is not so hard...
#100

@manuelmeister
Copy link
Collaborator Author

@jonnitto thank you for the review! I've either fixed those issues or added them to the cleanup task (#105). Could you take another look?

@manuelmeister
Copy link
Collaborator Author

manuelmeister commented Dec 22, 2022 •
edited
Loading

Meeting with @rolandschuetz

Next steps

@rolandschuetz rolandschuetz self-requested a review December 22, 2022 16:11
rolandschuetz
rolandschuetz requested changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@rolandschuetz rolandschuetz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few change requests

@manuelmeister
Copy link
Collaborator Author

@rolandschuetz I've implemented the requested changes.

manuelmeister and others added 4 commits January 9, 2023 15:00
@manuelmeister
Fix LocalNavigation after last try to remove the context
3e1de43 
Signed-off-by: Manuel Meister <[email protected]>
@manuelmeister
Improve active state rendering of IntersectionObserver
ad1c236 
Signed-off-by: Manuel Meister <[email protected]>
@manuelmeister
Merge remote-tracking branch 'upstream/task/neos-81-upgrade' into fea…
c3e0be3 
…ture/improve-ui

# Conflicts:
#	DistributionPackages/Neos.DocsNeosIo/Resources/Private/Fusion/Component/Navigation/Navigation.LevelRenderer.fusion
#	DistributionPackages/Neos.DocsNeosIo/Resources/Private/Fusion/Override/Flowpack.SearchPlugin/DocumentSearchResult.fusion
#	DistributionPackages/Neos.DocsNeosIo/Resources/Private/Fusion/Override/Flowpack.SearchPlugin/DocumentSearchResult.html
@markusguenther
Merge branch 'master' into feature/improve-ui
f4ef1f7
@markusguenther
Copy link
Member

Seems that I am not allowed to update the branch ;)

@manuelmeister
Copy link
Collaborator Author

@markusguenther fixed it :)

@manuelmeister manuelmeister mentioned this pull request Jan 22, 2023
Merged
@manuelmeister manuelmeister dismissed jonnitto’s stale review January 22, 2023 10:10

Fixed some issues and opened a new issue #105 for the remaining improvements

@Sebobo Sebobo merged commit 3b8414d into neos:master Jan 25, 2023
@manuelmeister manuelmeister deleted the feature/improve-ui branch January 25, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign left review comments

@Sebobo Sebobo Sebobo left review comments

@rolandschuetz rolandschuetz rolandschuetz approved these changes

@jonnitto jonnitto Awaiting requested review from jonnitto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@manuelmeister @crydotsnake @kdambekalns @robertlemke @mhsdesign @markusguenther @rolandschuetz @Sebobo @jonnitto