FEATURE: Improve service provider listing #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 8, 2023 09:45
* replace ninja icon for search results with an search results text
…provider listing
…ptimize spacings
crydotsnake
changed the title
crydotsnake
requested changes
Sep 8, 2023
DistributionPackages/Neos.NeosIo.ServiceOfferings/Resources/Private/Translations/de/Main.xlf
Outdated
Show resolved
Hide resolved
…ivate/Translations/de/Main.xlf Co-authored-by: Simon Krull <[email protected]>
* replace ninja icon for search results with an search results text
…ptimize spacings
…' into feature/service-provider-listing # Conflicts: # DistributionPackages/Neos.NeosIo.ServiceOfferings/Resources/Private/Translations/de/Main.xlf # DistributionPackages/Neos.NeosIo/Resources/Private/Scss/Organisms/_KeyVisual.scss
Sebobo
requested changes
Sep 28, 2023
...butionPackages/Neos.NeosIo.ServiceOfferings/Resources/Private/JavaScript/ProviderListing.tsx
Show resolved
Hide resolved
|
@NicoleNitschke thx, looks good now, but the filters are not visible on mobile. Was that intentionally? I noticed as I set a filter then switched to mobile and had no way to show all providers again. |
@Sebobo Yes, this is how it works on live today and I didn't change it, because it was not part of this ticket. But I agree with you, I would like to have these options in the mobile version, too - so I could open a new issue for this topic to get this one finished. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like in #517 described, I improved the filter bar and made the keyvisual section a bit smaller for showing more content above-the-fold. The ninja-icon was replaced by a user-friendly text which explains the search results.
The optimized filters look cleaner now: