-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPIC: Rewrite the MVC Dispatcher #2156
Comments
/cc @sorenmalling |
The firewall is also handled inside the Dispatcher. This could be moved out as a middleware in such a iteration |
Assigned @albe and myself to hold os accountable on the other side of the Flow 7.0 release :) |
One idea: Let's move the currently deprecated We could even do this right now already. |
Ill move the |
With the introduction of the PSR-15 middlewares (#1928 and #2019) we cover the whole HTTP dispatch process in a standard and extendable way. At the inner core of this middleware process is currently the MVC dispatcher, which is responsible to convert an Http request to an
ActionRequest
, resolving aController
, dispatching theActionRequest
to thatController
and receiving or wrapping the action return value in anActionResponse
, which is then converted into an Http Response that is further piped through the PSR-15 middlewares.The
ActionRequest
andActionResponse
abstractions give a nice high level abstraction of the underlying http messages, but currently it's not possible to interact with those in a cross-cutting concern other than inside the controller. Also, the MVC dispatcher currently holds a couple of responsibilities (resolving controller, looping the dispatch attempts, handling authentication errors, etc.). Therefore it might be benefitial to split the dispatcher into another middleware layer that acts upon anActionRequest
and anActionResponse
.Related / Todos:
ActionResponse
(simpler controller pattern) #3232The text was updated successfully, but these errors were encountered: