Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to run adjustments and custom processing on all rendered images #1469

Open
2 of 3 tasks
Sebobo opened this issue Mar 27, 2017 · 0 comments
Open
2 of 3 tasks

Comments

@Sebobo
Copy link
Member

Sebobo commented Mar 27, 2017

Description

Currently the ThumbnailService returns the original image if the size is not changed or a larger image is requested than the original.

This makes it impossible to optimize images via the Moc/ImageOptimizer package (mocdk/MOC.ImageOptimizer#14) and similar techniques, as the method refreshThumbnail is never called and cannot be hooked into to do post-processing.

The solution from #1178 is not enough to solve this as it also doesn't allow using custom libraries and behavior.

Expected behavior

The ThumbnailService should have a option to always force the generation of thumbnails and therefore allow post-processing of all images.

Actual behavior

  1. Create thumbnail from image which is same or larger than the one requested
  2. The original unmodified image is returned and no thumbnail variant generated

Affected Versions

Neos:

2.3
3.0

  • Run all images through ThumbnailGenerator class
  • Extract processResource method to allow changing the behavior via custom generators
  • Allow modification of the $adjustments array in the generator via configuration
@Sebobo Sebobo self-assigned this Mar 27, 2017
@Sebobo Sebobo changed the title Allow forcing of thumbnail generation in ThumbnailService Make it possible to run adjustments and custom processing on all rendered images Mar 28, 2017
@Sebobo Sebobo removed their assignment Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant