-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul ContentCacheFlusher #5175
Labels
Comments
dlubitz
added a commit
to dlubitz/neos-development-collection
that referenced
this issue
Aug 23, 2024
dlubitz
added a commit
to dlubitz/neos-development-collection
that referenced
this issue
Aug 26, 2024
dlubitz
added a commit
to dlubitz/neos-development-collection
that referenced
this issue
Aug 26, 2024
dlubitz
added a commit
to dlubitz/neos-development-collection
that referenced
this issue
Aug 27, 2024
dlubitz
added a commit
to dlubitz/neos-development-collection
that referenced
this issue
Aug 27, 2024
dlubitz
added a commit
to dlubitz/neos-development-collection
that referenced
this issue
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment the ContentCacheFlusher can't flush caches discarded nodes. This seems to be caused by the fact, that after persisting the change (discard), the ContentCacheFlusher tries to identify his parents, which is not possible anymore.
To solve this issue, we need to do all node traversing operation BEFORE the persistence. Which should be done in the GraphProjectorCatchUpHookForCacheFlushing. So the ContentCacheFlusher does not need to do any node traversing anymore and simply flush all given caches.
Currently this doesn't have a effect, as the cacheEntryIdentifier is based on the contentStreamId, which leads to orphan cache entries after each new contentStream creation. On the other hand, the cache entry is not used anymore after discard, which means the same as a cache flush of the entry.
See also:
The text was updated successfully, but these errors were encountered: