Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Deleted nodes in a workspace reappear on copy #5185

Closed
1 task done
Sebobo opened this issue Jul 25, 2024 · 0 comments
Closed
1 task done

BUG: Deleted nodes in a workspace reappear on copy #5185

Sebobo opened this issue Jul 25, 2024 · 0 comments
Assignees
@Sebobo
Labels
8.3 Bug

Comments

@Sebobo
Copy link
Member

Sebobo commented Jul 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Deleted content on a page reappears when a page is copied as the method \Neos\ContentRepository\Domain\Model\NodeData::similarize ignores the removed state.

Expected Behavior

The deleted text should not reappear on the copied page.

Steps To Reproduce

  1. Add a new page ein the demo.
  2. Add a text content "I should not exist"
  3. Publish everything
  4. Delete the text (Don't publish)
  5. Copy the page
  6. The text appears on the copied page

Environment

- Flow: 8.3
- Neos: 8.3
- PHP: any

Anything else?

No response
Sebobo added a commit that referenced this issue Jul 25, 2024
@Sebobo
BUGFIX: Don’t copy removed nodes
d5687fd 
With this change, removed nodes are not copied anymore
in the recursive copy actions. Also the removed state is kept
when a node is similarisied to prevent unpublished removed
nodes from popping up again inadvertendly.

Resolves: #5185
@Sebobo Sebobo self-assigned this Jul 25, 2024
@Sebobo Sebobo mentioned this issue Jul 25, 2024
Merged
Sebobo added a commit that referenced this issue Jul 25, 2024
@Sebobo
BUGFIX: Don’t copy removed nodes
0a8de51 
With this change, removed nodes are not copied anymore
in the recursive copy actions. Also the removed state is kept
when a node is similarisied to prevent unpublished removed
nodes from popping up again inadvertendly.

Resolves: #5185
@dlubitz dlubitz closed this as completed in 6936b7b Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sebobo Sebobo

Labels
8.3 Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sebobo