Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Allow NodeAggregate based transformations on AggregateProperties and Properties with same value #5213

Open
dlubitz opened this issue Aug 16, 2024 · 0 comments

Comments

@dlubitz
Copy link
Contributor

dlubitz commented Aug 16, 2024

To be able to restructure NodeTypes, we want to enable integrators to write node migrations based on property filter with NodeAggregate based transformations.

E.g:

comments: 'Migrate NodeType based on property value'
migration:
  - filters:
      - type: 'NodeType'
        settings:
          nodeType: 'Some.Old:NodeType'
      - type: 'PropertyValue'
        settings:
          propertyName: 'someProperty'
          serializedValue: true
    transformations:
      - type: 'ChangeNodeType'
        settings:
          newType: 'Some.New:NodeType'

Current behavior
At the moment this throws an error NodeAggregate Based transformations are only supported without any node based filters.

Targeted behavior
We want to implement an exception from this rule, which would allow to migrate NodeAggregates also on property based filters in following cases:

  • The property in the filter is a AggregateProperty -> we know the value is the same for all nodes
  • All properties are equal in all dimensions -> we can safely change the NodeType as all nodes have the same value in the filtered propery.

Releated to: #5190

Note: This was discussed in the developer weekly on 16.08.2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant