Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ConvertUrisImplementation more extensible #854

Closed
neos-bot opened this issue Aug 4, 2015 · 5 comments
Closed

Make the ConvertUrisImplementation more extensible #854

neos-bot opened this issue Aug 4, 2015 · 5 comments
Labels

Comments

@neos-bot
Copy link
Contributor

neos-bot commented Aug 4, 2015

Jira issue originally created by user michael.gerdemann:

Convert the anonymous function to a normal method, so that the ConvertUrisImplementation is expandable via an aspect.

Jira-URL: https://jira.neos.io/browse/NEOS-1477

@mhsdesign
Copy link
Member

@gerdemann was it about this line?

$processedContent = preg_replace_callback(LinkingService::PATTERN_SUPPORTED_URIS, function (array $matches) use ($node, $linkingService, $controllerContext, &$unresolvedUris, $absolute) {

its been a long time ^^ do you think it would still be helpful?

@kitsunet
Copy link
Member

Generally ConvertUrisImplementation could be better expandable

@mhsdesign
Copy link
Member

see also #3486

@gerdemann
Copy link
Contributor

I don't need that any more at the moment. But it might still be cool to be able to adjust it in case of doubt.

@mhsdesign
Copy link
Member

closing if favor of #3155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants