"Entity has to be managed or scheduled for removal for single computation" on publish moved nodes

[dlubitz]

Description
If I move a node to a parent, where already a sourceuripath exists, because the node was moved away from this parent before, the Doctrine Entitymanager throws an exception "Entity has to be managed or scheduled for removal for single computation".

Steps to reproduce

• Create a node in two dimensions and publish all
• Move the node below a new parent and publish all
• Move the node back to old parent and publish all (if you publish each dimension alone, it works)

What I already know
This behavior started with doctrine/orm: "2.19.5", caused by this change: doctrine/orm#11428

The UnitOfWork checks the state of each entity on change set computation: https://github.com/doctrine/orm/blob/2.19.x/src/UnitOfWork.php#L573

This seems to be affected by the change above.

Might be related: doctrine/orm#11480

Affected Version: 5.0.4

[kdambekalns]

What about catching the exception instead of checking the state? If that is an exceptional case (as an exception should be), that might be cheaper…

[dlubitz]

Hmm, yes. This works too. But in both cases we rely somehow on internal logic of doctrine.

[kdambekalns]

But in both cases we rely somehow on internal logic of doctrine.

True. But catching an exception seems "more distant" than checking a state because you know that's what raises an exception. No?

[dlubitz]

I like the "second account" apporach. Feels more crowdy here. 😁

EDIT: Damn it, you tricked me