Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyError occurs when CMS toolbar is visible in Django CMS 3.11.8 #214

Closed
jdgoettsch opened this issue Sep 11, 2024 · 5 comments · Fixed by #215
Closed

KeyError occurs when CMS toolbar is visible in Django CMS 3.11.8 #214

jdgoettsch opened this issue Sep 11, 2024 · 5 comments · Fixed by #215
Labels
status: feedback needed type: bug

Comments

@jdgoettsch
Copy link
Contributor

jdgoettsch commented Sep 11, 2024 •
edited
Loading

Description

PageToolbarMeta.populate uses incorrect permission name to check if a user has change permission on the current page, causing a KeyError to be raised with django-cms >= 3.11.8.

Steps to reproduce

  1. Install djangocms-page-meta with django-cms 3.11.8.
  2. Log into your website and visit any page with the toolbar visible.

Versions

Python 3.10.14
Django 4.2.16
django-cms. 3.11.8

Expected behaviour

Page loads without crashing.

Actual behaviour

KeyError occurs and page crashes.

Additional information

In djangocms_page_meta/cms_toolbars.py on line 39, "change" should instead be "change_page".
@jdgoettsch jdgoettsch mentioned this issue Sep 11, 2024
Merged
3 tasks
@tschale
Copy link

tschale commented Oct 25, 2024 •
edited
Loading

Thank you for the fix! What's the state of it? Is there a timeline for its release?

@protoroto protoroto reopened this Jan 14, 2025
@protoroto
Copy link
Member

@tschale @jdgoettsch Hi everyone! I've just released 1.4.5 version with the fix from @jdgoettsch . Could you please check and report if everything works as expected now?

@tschale
Copy link

tschale commented Jan 14, 2025

@tschale @jdgoettsch Hi everyone! I've just released 1.4.5 version with the fix from @jdgoettsch . Could you please check and report if everything works as expected now?

Thank you! I'll write as soon as I've tried it out. It might take a couple of weeks though, until I work on that project again.

@tschale
Copy link

tschale commented Jan 29, 2025

@protoroto This works now (django-cms 3.11.9, django 4.2.18). Thank you and also @jdgoettsch!

@protoroto
Copy link
Member

@tschale Thanks for the feedback! I'll close this issue then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: feedback needed type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug/#214-Fix misnamed 'change_page' permission jdgoettsch/djangocms-page-meta
3 participants
@tschale @protoroto @jdgoettsch