-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out Preprocessing #4
Comments
@jakpra Do you want to work on this one? |
Sure. I'd like to go about this by looking for general (linguistic/structural?) patterns within each framework and across frameworks. I'll look into the attribute formatting; I guess a simple workaround could just be to comment out those lines that would ignore the "bad" ones... But most importantly, we should check what makes them "bad" and what the shared task has to say about that. |
|
Preprocessing in the parser is based on Zhang et al. 2019 and only works on AMRs. We need to figure out whether/how we want to handle preprocessing of UCCA, EDS, DRG, and PTG.
I think to get the preprocessing working on the new data, you only need to modify AMRIO to look more like AMRGraph.
One possible consequence of working without preprocessing:
AMRGraph.py
apparently expects attributes to be in a particular format or else it ignores them (line 63). While working on the parser without preprocessing, this basically results in all attributes being ignored.The text was updated successfully, but these errors were encountered: