Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unmaintained atty dependency #4196

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Remove unmaintained atty dependency #4196

merged 2 commits into from
Oct 17, 2023

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Oct 17, 2023 •
edited
Loading

What problem does this PR solve?

CKB's logger-service depend on an unmaintained and old atty package, atty will dereference a potentially unaligned pointer on Windows platform: https://github.com/nervosnetwork/ckb/security/dependabot/15

This PR want to upgrade env-logger from v0.6.2 to v0.10.0, then CKB won't need atty anymore.

What is changed and how it works?

What's Changed:

Related changes

  • upgrade env-logger from v0.6.0 to 0.10.0, remove atty from logger-service's dependencies

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner October 17, 2023 04:12
@eval-exec eval-exec requested review from quake and removed request for a team October 17, 2023 04:12
@doitian doitian added this pull request to the merge queue Oct 17, 2023
Merged via the queue into nervosnetwork:develop with commit 7d93a8f Oct 17, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @doitian