From d168e735e972785f0509cb400ab153c60ae64c31 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E4=B8=A5=E5=9B=BD=E5=AE=87?= <841185308@qq.com> Date: Mon, 20 Nov 2023 08:29:44 +0800 Subject: [PATCH] fix: It's unnecessary to use process.exit to skip create PR. (#2947) --- .github/workflows/update_ckb_client_versions.yml | 2 +- .github/workflows/update_neuron_compatible.yml | 2 -- compatible.json | 2 +- scripts/add-neuron-version-in-compatibility-table.js | 2 -- 4 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/update_ckb_client_versions.yml b/.github/workflows/update_ckb_client_versions.yml index 9f978ded31..e661523a23 100644 --- a/.github/workflows/update_ckb_client_versions.yml +++ b/.github/workflows/update_ckb_client_versions.yml @@ -25,7 +25,7 @@ jobs: id: update_versions run: | npm run update:client-versions - git add .ckb-version .ckb-light-version + git add .ckb-version .ckb-light-version compatible.json - name: Set GPG uses: crazy-max/ghaction-import-gpg@v5 diff --git a/.github/workflows/update_neuron_compatible.yml b/.github/workflows/update_neuron_compatible.yml index c95d5751c7..19363afadd 100644 --- a/.github/workflows/update_neuron_compatible.yml +++ b/.github/workflows/update_neuron_compatible.yml @@ -31,7 +31,6 @@ jobs: git add compatible.json - name: Set GPG - if: ${{ success() }} uses: crazy-max/ghaction-import-gpg@v5 with: gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }} @@ -40,7 +39,6 @@ jobs: git_commit_gpgsign: true - name: Open PR to RC branch - if: ${{ success() }} uses: peter-evans/create-pull-request@v5 with: title: Update Neuron compatibility table diff --git a/compatible.json b/compatible.json index 732472a581..4d1db91ee1 100644 --- a/compatible.json +++ b/compatible.json @@ -54,4 +54,4 @@ "light": [] } } -} +} diff --git a/scripts/add-neuron-version-in-compatibility-table.js b/scripts/add-neuron-version-in-compatibility-table.js index b2d2772754..28d755a3cd 100644 --- a/scripts/add-neuron-version-in-compatibility-table.js +++ b/scripts/add-neuron-version-in-compatibility-table.js @@ -18,8 +18,6 @@ const exec = () => { if (newNeuronVersion && lastNeuronVersion !== newNeuronVersion) { info.compatible[newNeuronVersion] = info.compatible[lastNeuronVersion] fs.writeFileSync(compatiblePath, `${JSON.stringify(info, null, 2)}\r\n`) - } else { - process.exit(1) } }