Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix rc/110.3 bugs, detail in comments #2849

Merged
merged 6 commits into from
Sep 28, 2023

Conversation

yanguoyu
Copy link
Collaborator

@yanguoyu yanguoyu commented Sep 25, 2023

  1. Fix styles when the desc or symbol is overlong
  2. Close dialog when submitting success with migrating to create a new account
  3. Reset the deposit value when the dialog's visible changes and show an error dialog when the deposit fails.
  4. Ignore update the transaction that calls get_transaction failed.

@silySuper
Copy link
Collaborator

silySuper commented Sep 25, 2023

/package
Packaging for test is done in 6296255661. @silySuper

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Sep 26, 2023

/package
Packaging for test is done in 6307540525. @yanguoyu

@Keith-CY
Copy link
Collaborator

Keith-CY commented Sep 26, 2023

Clear tx should be performed on initialization, e.g. when the deposit dialog opens, instead of the workflow end. Otherwise, the initial tx may be affected by other workflows. For example,

  1. open a deposit dialog and enter a value
  2. close the dialog and the tx is cleared
  3. do some work and a tx is generated, but the post-treat is missing by accident
  4. open a deposit dialog, the tx generated in step 3 will be the initial one

To be precise, it's a reset of initial tx

@yanguoyu
Copy link
Collaborator Author

Clear tx should be performed on initialization, e.g. when the deposit dialog opens, instead of the workflow end. Otherwise, the initial tx may be affected by other workflows. For example,

  1. open a deposit dialog and enter a value
  2. close the dialog and the tx is cleared
  3. do some work and a tx is generated, but the post-treat is missing by accident
  4. open a deposit dialog, the tx generated in step 3 will be the initial one

To be precise, it's a reset of initial tx

Actually, when the deposit dialog opens, the transaction will be refreshed. It shows the last deposit value because the deposit dialog was not destroyed. So the last deposit value exists. So I reset the deposit value when the dialog visible changes at 045d09b

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Sep 26, 2023

/package
Packaging for test is done in 6308097897. @yanguoyu

@silySuper
Copy link
Collaborator

Asset Accounts-Receive page shows abnormal when token name is long.

截屏2023-09-26 15 26 14

@silySuper
Copy link
Collaborator

silySuper commented Sep 26, 2023

History page shows abnormal when token name is long.Overview page is the same too.

2023-09-26.15.27.59.mov
2023-09-26.15.30.41.mov

@yanguoyu
Copy link
Collaborator Author

@silySuper Fixed by a97012f

@silySuper
Copy link
Collaborator

silySuper commented Sep 27, 2023

/package
Packaging for test is done in 6320350014. @silySuper

@yanguoyu yanguoyu changed the title Fix: fix styles and action Fix: fix rc/110.3 bugs, detail in comments Sep 27, 2023
@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Sep 27, 2023

/package
Packaging for test is done in 6322640453. @yanguoyu

@Keith-CY
Copy link
Collaborator

Everything works well on my computer now.

@silySuper
Copy link
Collaborator

silySuper commented Sep 28, 2023

/package
Packaging for test is done in 6333486854. @silySuper

@Keith-CY Keith-CY added this pull request to the merge queue Sep 28, 2023
Merged via the queue into nervosnetwork:develop with commit 70cb7fd Sep 28, 2023
10 checks passed
@yanguoyu yanguoyu deleted the fix-asset-style branch April 28, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants