Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support import hardware wallet 24-bit seed #3275

Merged
merged 1 commit into from
Dec 12, 2024
Merged

feat: Support import hardware wallet 24-bit seed #3275

merged 1 commit into from
Dec 12, 2024

Conversation

yanguoyu
Copy link
Collaborator

This PR will not merged. I open a draft PR.

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Dec 10, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 12251346835. @yanguoyu

@yanguoyu yanguoyu mentioned this pull request Dec 10, 2024
Open
@Keith-CY
Copy link
Collaborator

Is this feature ready for testing?

@yanguoyu
Copy link
Collaborator Author

Is this feature ready for testing?

Sure

@Keith-CY Keith-CY changed the base branch from develop to rc/import-ledger-mnemonics December 11, 2024 06:34
@Keith-CY
Copy link
Collaborator

Is this feature ready for testing?

Sure

@silySuper Please have a test with 24-word mnemonics and check if

  1. is the address the same as when neuron is connected to ledger
  2. transaction can be signed and submitted to the chain

@silySuper
Copy link
Collaborator

2024-12-11.15.08.26.mov

It is abnormal that send transaction does not need ledger confirm when use wallet imported by 24 keywords.

@silySuper
Copy link
Collaborator

Have cofirmed that it can use password directly.
Verified.

@Keith-CY
Copy link
Collaborator

Please mark this PR ready for review so we can merge it into an RC branch for the official package.

@yanguoyu yanguoyu marked this pull request as ready for review December 11, 2024 07:25
@yanguoyu yanguoyu force-pushed the feat-import-hardware-seed branch from 069c4b7 to 1ad4164 Compare December 11, 2024 07:41
@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Dec 11, 2024 •
edited by github-actions bot
Loading

/package
Fixed the wallet that imports from seed is unnecessary to show verify address.
Packaging for test is done in 12271828695. @yanguoyu

@silySuper
Copy link
Collaborator

verify function is deleted.

@Keith-CY
Copy link
Collaborator

Please have a review @homura @devchenyan

1 similar comment
@Keith-CY
Copy link
Collaborator

Please have a review @homura @devchenyan

@yanguoyu yanguoyu force-pushed the feat-import-hardware-seed branch from 1ad4164 to d4df2a9 Compare December 12, 2024 07:11
homura
homura approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@homura homura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to be manually tested with the 24-word mnemonic feature

@Keith-CY
Copy link
Collaborator

This PR needs to be manually tested with the 24-word mnemonic feature

@silySuper should have done the test, please confirm again

@silySuper
Copy link
Collaborator

2024-12-11.15.08.26.mov
It is abnormal that send transaction does not need ledger confirm when use wallet imported by 24 keywords.

Function has verified manually yesterday,this wallet in video is created by 24-words which was from my ledger . @Keith-CY @homura

@Keith-CY Keith-CY merged commit 9dca6eb into nervosnetwork:rc/import-ledger-mnemonics Dec 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devchenyan devchenyan devchenyan approved these changes

@homura homura homura approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yanguoyu @Keith-CY @silySuper @homura @devchenyan