Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Optimize Sign/verify Message #3293

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: Optimize Sign/verify Message #3293

wants to merge 4 commits into from

Conversation

devchenyan
Copy link
Collaborator

@devchenyan devchenyan commented Jan 7, 2025 •
edited
Loading

issue: Magickbase/neuron-public-issues#432

Screen-2025-01-07-105139.mp4

@devchenyan devchenyan mentioned this pull request Jan 7, 2025
Open
@yanguoyu
Copy link
Collaborator

yanguoyu commented Jan 8, 2025

We should verify whether the entered address belongs to the current wallet. Otherwise, it will also sign failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@homura homura Awaiting requested review from homura

@yanguoyu yanguoyu Awaiting requested review from yanguoyu

@silySuper silySuper Awaiting requested review from silySuper

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devchenyan @yanguoyu @Keith-CY