Skip to content
This repository has been archived by the owner on Oct 22, 2022. It is now read-only.

Tracing config support #75

Open
zrzka opened this issue Apr 25, 2017 · 2 comments
Open

Tracing config support #75

zrzka opened this issue Apr 25, 2017 · 2 comments

Comments

@zrzka
Copy link
Contributor

zrzka commented Apr 25, 2017

There's new switch in the awscli for update-function-configuration:

       --tracing-config (structure)
          The parent object that contains your function's tracing settings.

       Shorthand Syntax:

          Mode=string

       JSON Syntax:

          {
            "Mode": "Active"|"PassThrough"
          }

It's AWS X-Ray related and I would like to add support for it. Proposal is:

:defaults {:tracing :active}
  • :tracing can be used in :defaults and per lambda function
  • :tracing values can be :active or :passthrough
  • If :tracing is not provided, it defaults to :passthrough

It defaults to :passthrough, because it's a default value for all AWS Lambda functions (checked via awscli).

Okay?

@moea
Copy link
Member

moea commented Apr 25, 2017

Yeah, that's fine. If it's possible to not emit a CLI arg in the case that the config doesn't specify :tracing, that would relax the requirement that all users have to update their CLI. Not the end of the world either way.

@zrzka
Copy link
Contributor Author

zrzka commented Apr 25, 2017

I already did it here: https://github.com/zrzka/cljs-lambda/tree/tracing

I understand your issue with not emitting --tracing-config when it's not specified, but on the other side, it will create synchronization & comparison mess in local vs remote comparison -> fire or not fire update-function-configuration. I'd rather fire it always. This is the same issue as it was with VPC, devs were forced to update awscli to use VPC. I don't see it as an issue, but your project, decide ;-)

@zrzka zrzka mentioned this issue Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants