Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cljs plugin does not exclude dev dependencies #28

Open
arichiardi opened this issue Oct 6, 2017 · 4 comments
Open

Cljs plugin does not exclude dev dependencies #28

arichiardi opened this issue Oct 6, 2017 · 4 comments

Comments

@arichiardi
Copy link
Contributor

I have run against this problem a couple of times now and this I have decided to investigate.

So given that we are not using the zipService provided by the Serverless Framework to zip up our stuff we don't mimic (I guess by design) its standard behavior. That's unfortunate.

There are two solutions to this (but maybe more, open to suggestions):

  • Make so that we use the zipService above in index.js and then both lumo and lein would just reopen and append to the zip file.
  • Reimplement the same behavior in both plugins.

I think option one is more work but also probably the right thing to do, but I am also wondering if there is a way not to skip the packaging step (just provide a custom zip name to it).

Any other idea?

@arichiardi
Copy link
Contributor Author

I actually see that if the compiler just does its job of copying the files in the root of the project, Serverless will just pick it up and zip itself. So my question is now, what am I missing? Why is this plugin doing the zipping?

@arichiardi
Copy link
Contributor Author

Ok so I think I found out why, PR coming.

@ckirkendall
Copy link

ckirkendall commented Aug 31, 2018

Any update on this? I am seeing this issue today. @arichiardi

@arichiardi
Copy link
Contributor Author

@ckirkendall I thought I fixed this? Cannot recall now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants