You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! Not an issue, but perhaps an enhancement to make fitting RV data for multi-planet systems more user-friendly. The docs specify that for multi-planet systems, the planetary periods must be in 'chronological order'. So lets say I have a two-planet system with planet b having a 10-day period and planet c a 30-day period. If I try to fit RV data for this system, fixing the periods to those 'literature' values, and choose planet c to be p1, I get the following error:
which is great and self-explanatory.
Instead, if I fix the period of planet c (p1) but put a prior on the period of planet b (p2) this exception is no longer raised - even when the prior constrains the period to always be shorter than 30-days (e.g. U(9,11) ). In this case, dataset.fit will run without error, but finish in one iteration and return nonsense, e.g., this printed output:
Thanks for opening this issue! I see your point, and I think you are right --- at least a warning should be raised indeed based on the support of the prior if it is disjoint with the others (including fixed periods).
Hi! Not an issue, but perhaps an enhancement to make fitting RV data for multi-planet systems more user-friendly. The docs specify that for multi-planet systems, the planetary periods must be in 'chronological order'. So lets say I have a two-planet system with planet b having a 10-day period and planet c a 30-day period. If I try to fit RV data for this system, fixing the periods to those 'literature' values, and choose planet c to be p1, I get the following error:
which is great and self-explanatory.
Instead, if I fix the period of planet c (p1) but put a prior on the period of planet b (p2) this exception is no longer raised - even when the prior constrains the period to always be shorter than 30-days (e.g. U(9,11) ). In this case,
dataset.fit
will run without error, but finish in one iteration and return nonsense, e.g., this printed output:In situations like this, I think it would be helpful to raise the same exception as above.
The text was updated successfully, but these errors were encountered: